Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/snapshot_create_volume_permission: Raise creation timeout to 20mins #2049

Merged
merged 1 commit into from
Oct 25, 2017
Merged

r/snapshot_create_volume_permission: Raise creation timeout to 20mins #2049

merged 1 commit into from
Oct 25, 2017

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Oct 25, 2017 •
edited
Loading

This is a second attempt to address the following test failure:

=== RUN   TestAccAWSSnapshotCreateVolumePermission_Basic
--- FAIL: TestAccAWSSnapshotCreateVolumePermission_Basic (662.59s)
    testing.go:434: Step 0 error: Error applying: 1 error(s) occurred:
        
        * aws_snapshot_create_volume_permission.self-test: 1 error(s) occurred:
        
        * aws_snapshot_create_volume_permission.self-test: Error waiting for snapshot createVolumePermission (snap-09d6818069913807b-*******) to be added: timeout while waiting for state to become 'granted' (last state: 'denied', timeout: 10m0s)

because #1894 clearly wasn't sufficient.

@radeksimko radeksimko added the bug Addresses a defect in current functionality. label Oct 25, 2017
Ninir
Ninir approved these changes Oct 25, 2017
View reviewed changes
Copy link
Contributor

@Ninir Ninir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@radeksimko radeksimko merged commit a1c3c62 into master Oct 25, 2017
@radeksimko radeksimko deleted the b-snapshot-vol-perm-timeout branch October 25, 2017 11:27
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ninir Ninir Ninir approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @Ninir